mihaibudiu commented on code in PR #4055:
URL: https://github.com/apache/calcite/pull/4055#discussion_r1850815916
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -121,6 +121,10 @@ public StarRocksSqlDialect(Context context) {
return new SqlDataTypeSpec(
new SqlBasicTypeNameSpec(SqlTypeName.BIGINT, SqlParserPos.ZERO),
SqlParserPos.ZERO);
+ case VARCHAR:
Review Comment:
VARCHAR(N) is supposed to truncate to N characters, and then trim the
whitespaces from the end of the string.
If the dialect does not support VARCHAR(N) perhaps it should report an error
when an attempt is made to use it.
Then you should also add an assertion that the precision is "not specified".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
