xiaochen-zhou commented on code in PR #4055:
URL: https://github.com/apache/calcite/pull/4055#discussion_r1849515813
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -121,6 +121,10 @@ public StarRocksSqlDialect(Context context) {
return new SqlDataTypeSpec(
new SqlBasicTypeNameSpec(SqlTypeName.BIGINT, SqlParserPos.ZERO),
SqlParserPos.ZERO);
+ case VARCHAR:
Review Comment:
> what happens to the precision if it is specified?
I initially thought that if precision is not set here, the default precision
for varchar might be used. However, I just looked at the code, and it seems
that if precision is not set, the default is PRECISION_NOT_SPECIFIED. Could
this lead to a loss of precision, or did I not look at the code carefully?
@mihaibudiu @caicancai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
