xiaochen-zhou commented on code in PR #4123:
URL: https://github.com/apache/calcite/pull/4123#discussion_r1903180117
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3747,6 +3747,30 @@ private SqlDialect nonOrdinalDialect() {
sql(query).dialect(mySqlDialect(NullCollation.LAST)).ok(expected);
}
+ @Test void testStarRocksCastToVarcharWithLessThanMaxPrecision() {
Review Comment:
> Do we need tests to cover `CHAR` and `VARBINARY` types?
I think CHAR might not be necessary since it is the same as in MySQL.
However, VARBINARY might need tests. I will add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
