suibianwanwank commented on code in PR #4145:
URL: https://github.com/apache/calcite/pull/4145#discussion_r1914643780
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java:
##########
@@ -84,9 +86,10 @@ private RelMdColumnOrigins() {}
Set<RelColumnOrigin> inputSet =
mq.getColumnOrigins(rel.getInput(), iInput);
inputSet = createDerivedColumnOrigins(inputSet);
- if (inputSet != null) {
- set.addAll(inputSet);
+ if (inputSet == null) {
+ return null;
Review Comment:
The logic here doesn't seem to fit the documentation.
`set of origin columns, or null if this information cannot be determined
(whereas empty set indicates definitely no
origin columns at all)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
