suibianwanwank commented on code in PR #4145:
URL: https://github.com/apache/calcite/pull/4145#discussion_r1917583563
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java:
##########
@@ -303,8 +306,16 @@ private static Set<RelColumnOrigin>
getMultipleColumns(RexNode rexNode, RelNode
}
return null;
}
+
+ @Override public Void visitFieldAccess(RexFieldAccess fieldAccess) {
Review Comment:
I'm not familiar with the type Row. If the type Row is also using
RexFieldAccess, there should be an error here.
RexFieldAccess will also be used for correlated variables, and the comments
in the RexFieldAccess:
```
* <p>but there is a specialized expression {@link RexInputRef} for this
* purpose. So in practice, <code>RexFieldAccess</code> is usually used to
* access fields of correlating variables, for example the expression
* <code>emp.deptno</code> in
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
