mihaibudiu commented on code in PR #4145:
URL: https://github.com/apache/calcite/pull/4145#discussion_r1917197302
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java:
##########
@@ -303,8 +306,16 @@ private static Set<RelColumnOrigin>
getMultipleColumns(RexNode rexNode, RelNode
}
return null;
}
+
+ @Override public Void visitFieldAccess(RexFieldAccess fieldAccess) {
Review Comment:
why does this indicate an access in a correlated variable?
could this be an access into a field with type ROW?
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdColumnOrigins.java:
##########
@@ -84,9 +86,10 @@ private RelMdColumnOrigins() {}
Set<RelColumnOrigin> inputSet =
mq.getColumnOrigins(rel.getInput(), iInput);
inputSet = createDerivedColumnOrigins(inputSet);
- if (inputSet != null) {
- set.addAll(inputSet);
+ if (inputSet == null) {
+ return null;
Review Comment:
where is the documentation you are mentioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
