mihaibudiu commented on code in PR #4144: URL: https://github.com/apache/calcite/pull/4144#discussion_r1915221155
########## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ########## @@ -405,8 +405,9 @@ private static RexNode rewriteSome(RexSubQuery e, Set<CorrelationId> variablesSe // from emp group by name) as q on e.name = q.name builder.push(e.rel) .aggregate(builder.groupKey(), - builder.count(true, "c"), - builder.count(true, "d", builder.field(0)), + builder.count(false, "c"), Review Comment: these would be very nice comments to add in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org