mihaibudiu commented on code in PR #4144:
URL: https://github.com/apache/calcite/pull/4144#discussion_r1917188838
##########
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##########
@@ -392,21 +392,22 @@ private static RexNode rewriteSome(RexSubQuery e,
Set<CorrelationId> variablesSe
// then false // sub-query is empty for corresponding corr value
// when q.c = 0 then false // sub-query is empty
// when e.deptno is null then unknown
- // when q.c <> q.d && q.d <= 1
+ // when q.c <> q.d && q.dd <= 1
Review Comment:
where is the summary you have written?
I think it's always best to have the code be self-explanatory.
Once someone makes any edit to this code finding the information residing in
other tools like git will become harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
