NobiGo commented on code in PR #4144: URL: https://github.com/apache/calcite/pull/4144#discussion_r1915837823
########## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ########## @@ -392,21 +392,22 @@ private static RexNode rewriteSome(RexSubQuery e, Set<CorrelationId> variablesSe // then false // sub-query is empty for corresponding corr value // when q.c = 0 then false // sub-query is empty // when e.deptno is null then unknown - // when q.c <> q.d && q.d <= 1 + // when q.c <> q.d && q.dd <= 1 Review Comment: Looks good to me. The logic here is a bit complicated, you can add corresponding code comments @racevedoo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org