chrisdennis commented on PR #251: URL: https://github.com/apache/calcite-avatica/pull/251#issuecomment-2616030986
> Since we're going for perfection, we may also want to reconsider callAs(). Apologies for triggering some (all?) of this bike-shedding. > Subject callAs() throws Exceptions, and the fallback path now also throws exceptions (wrapped in PrivilegedActionException). > I'm confused, Subject.callAs(...) throws `CompletionException` if the action throws, which is what the current code does, unwrapping any PrivilegedActionException and rewrapping it in case we're backed by the old `doAs(...)` method. The only tweak I'd make to the current code is that the `Exception` catch and rethrow is redundant given the `sneakyThrow(t)` call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
