stoty commented on PR #251: URL: https://github.com/apache/calcite-avatica/pull/251#issuecomment-2616579150
> I'm confused, Subject.callAs(...) throws `CompletionException` if the action throws, which is what the current code does, unwrapping any PrivilegedActionException and rewrapping it in case we're backed by the old `doAs(...)` method. The only tweak I'd make to the current code is that the `Exception` catch and rethrow is redundant given the `sneakyThrow(t)` call. You are right. However, since Subject.callAs() explicitly throws CompletionException, shouldn't SecurityUtils.callAs() also explictly throw CompletionException ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
