stoty commented on code in PR #274:
URL: https://github.com/apache/calcite-avatica/pull/274#discussion_r1949623527
##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -151,14 +154,21 @@ private RequestConfig createRequestConfig() {
}
@Override public byte[] send(byte[] request) {
Review Comment:
If you mean using the execute() calls that pass a Handler, those don't
return error codes, and would make implementing the retry logic unneccarily
convoluted.
The response is already in a try-with-resources block, so there is no danger
of leakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
