chrisdennis commented on code in PR #274:
URL: https://github.com/apache/calcite-avatica/pull/274#discussion_r1949671601
##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -151,14 +154,21 @@ private RequestConfig createRequestConfig() {
}
@Override public byte[] send(byte[] request) {
Review Comment:
Sorry - I've no idea why I wrote ensureOpen... you're right I mean't
`executeOpen(...)`. I'm not suggesting migrating to `execute(...)` calls
though. I meant that if you formulate things like above then you don't need to
compute the `HttpHost` in advance using a "dummy" HttpPost/URI, and you don't
need to pass the result in via the new instance variable, you can just reorder
things slightly, and keep everything contained within the call stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
