stoty commented on code in PR #274:
URL: https://github.com/apache/calcite-avatica/pull/274#discussion_r1949684091


##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -151,14 +154,21 @@ private RequestConfig createRequestConfig() {
   }
 
   @Override public byte[] send(byte[] request) {

Review Comment:
   Thanks for the clarification.
   
   Yes, that would work, but we're currently caching and pre-computing as much 
as possible.
   Your version is slightly less efficient, as it needs to call 
RoutingSupport.determineHost for each send() call.
   
   But we can avoid the Dummy post by postponing the host detection, I will do 
that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to