NobiGo commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r1970821560
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +132,52 @@ public StarRocksSqlDialect(Context context) {
timeUnitNode.getParserPosition());
SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC",
false);
break;
+ case IS_TRUE:
Review Comment:
Good catch. I overlooked this non-deterministic expression. If this
expression is non-deterministic, I will throw an exception. Or do you have any
other more general approaches for handling this situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
