mihaibudiu commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2021963077
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +132,72 @@ public StarRocksSqlDialect(Context context) {
timeUnitNode.getParserPosition());
SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC",
false);
break;
+ case IS_TRUE:
+ if (this.supportMacroLikeUnparse()) {
Review Comment:
This is probably not the only place where a rewrite could be wrong if a call
is not deterministic. I think it would be a useful feature to be able to detect
such calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
