NobiGo commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2021960638
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +132,72 @@ public StarRocksSqlDialect(Context context) {
timeUnitNode.getParserPosition());
SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC",
false);
break;
+ case IS_TRUE:
+ if (this.supportMacroLikeUnparse()) {
Review Comment:
My current approach is indeed a bit strange. Since this might not be within
the purview of SqlDialect, in StarRocksSqlDialect, it is not certain whether
this function is deterministic(SqlCall). If we make this judgment in
SqlImplementor, we need a list of unsupported functions to determine whether to
rewrite it. This list is used to write functions that Dialect does not support
and which might be non-deterministic. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
