xiedeyantu commented on code in PR #4249:
URL: https://github.com/apache/calcite/pull/4249#discussion_r1997637174
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -383,6 +383,7 @@ private static String toSql(RelNode root, SqlDialect
dialect,
final String expectedClickHouse = "SELECT PI()";
final String expectedPresto = "SELECT PI()\n"
+ "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
+ final String expectTrino = expectedPresto;
Review Comment:
I also suggest directly extends the Presto dialect, and if there are no
differences in the test, the test file can be left unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
