xuzifu666 commented on code in PR #4249:
URL: https://github.com/apache/calcite/pull/4249#discussion_r2006910693
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -1216,6 +1228,10 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "FROM \"foodmart\".\"product\"\n"
+ "GROUP BY ROLLUP(\"product_class_id\")\n"
+ "LIMIT 5";
+ final String expectedTrino = "SELECT \"product_class_id\", COUNT(*) AS
\"C\"\n"
Review Comment:
Other dialects would support fetch next syntax first if they supported, and
the change here is different from presto, so I prefer keep it the same with
other dialect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
