caicancai commented on code in PR #4249:
URL: https://github.com/apache/calcite/pull/4249#discussion_r2001212538
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -393,6 +394,7 @@ private static String toSql(RelNode root, SqlDialect
dialect,
.withMysql().ok(expectedMysql)
.withClickHouse().ok(expectedClickHouse)
.withPresto().ok(expectedPresto)
+ .withTrino().ok(expectedPresto)
Review Comment:
Not necessarily. Once Julian's test suite is complete, it may be more
appropriate to have one test suite for each dialect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
