caicancai commented on code in PR #4247:
URL: https://github.com/apache/calcite/pull/4247#discussion_r2014063084
##########
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java:
##########
@@ -181,6 +188,21 @@ private static SqlDataTypeSpec
createSqlDataTypeSpecByName(String typeAlias,
return;
}
+ if (call.getOperator() instanceof SqlFilterOperator) {
+ SqlCall aggCall = call.operand(0);
+ if (call.getOperandList().size() > 1 && call.operand(1) != null) {
+ SqlCall filterCondition = call.operand(1);
+ String functionName = aggCall.getOperator().getName();
+ writer.print(functionName.toLowerCase(Locale.ROOT) + "If");
Review Comment:
No, according to your writing above, all aggregate functions will execute
the logic of your method. If some functions of ClickHouse are not supported by
Calcite, you at least need to record JavaDoc for explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
