xiedeyantu commented on code in PR #4247:
URL: https://github.com/apache/calcite/pull/4247#discussion_r2016189777
##########
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java:
##########
@@ -181,6 +188,21 @@ private static SqlDataTypeSpec
createSqlDataTypeSpecByName(String typeAlias,
return;
}
+ if (call.getOperator() instanceof SqlFilterOperator) {
+ SqlCall aggCall = call.operand(0);
+ if (call.getOperandList().size() > 1 && call.operand(1) != null) {
+ SqlCall filterCondition = call.operand(1);
+ String functionName = aggCall.getOperator().getName();
+ writer.print(functionName.toLowerCase(Locale.ROOT) + "If");
Review Comment:
Well, I understand. We may not need this PR. Correctly supporting function
conversion may be a problem faced by all dialects. If this PR only handles some
aggregation functions supported by ClickHouse, it may not be a good solution.
So I will temporarily close this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
