caicancai commented on code in PR #4247:
URL: https://github.com/apache/calcite/pull/4247#discussion_r2014068819
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -361,7 +361,13 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "FROM `foodmart`.`product`\n"
+ "WHERE `product_id` > 0\n"
+ "GROUP BY `product_id`";
+ final String expectedClickHouse = "SELECT"
Review Comment:
Can you add more tests for different types of aggregate functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
