mihaibudiu commented on code in PR #4290:
URL: https://github.com/apache/calcite/pull/4290#discussion_r2038928184
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -9110,10 +9115,26 @@ private void checkLiteral2(String expression, String
expected) {
final String expectedTrino = expectedPresto;
final String expectedSpark = "SELECT MAP (ARRAY ('k1', 'k2'), ARRAY ('v1',
'v2'))\n"
+ "FROM (VALUES (0)) `t` (`ZERO`)";
+ final String expectedClickHouse = "SELECT map(array('k1', 'k2'),
array('v1', 'v2'))";
sql(query)
.withPresto().ok(expectedPresto)
.withTrino().ok(expectedTrino)
- .withSpark().ok(expectedSpark);
+ .withSpark().ok(expectedSpark)
+ .withClickHouse().ok(expectedClickHouse);
+ }
+
+ @Test void testEmptyMapOrArrayValueConstructor() {
Review Comment:
these tests are not really useful, since they do not exercise your new
changes.
but perhaps these tests cannot currently be written.
I apologize for the confusion. Let's delete them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
