xuzifu666 commented on code in PR #4290:
URL: https://github.com/apache/calcite/pull/4290#discussion_r2036410163
##########
core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java:
##########
@@ -216,6 +216,24 @@ private static SqlDataTypeSpec
createSqlDataTypeSpecByName(String typeAlias,
}
switch (call.getKind()) {
+ case MAP_VALUE_CONSTRUCTOR:
+ writer.print(call.getOperator().getName().toLowerCase(Locale.ROOT));
+ final SqlWriter.Frame mapFrame = writer.startList("(", ")");
+ for (int i = 0; i < call.operandCount(); i++) {
+ writer.sep(",");
+ call.operand(i).unparse(writer, leftPrec, rightPrec);
+ }
+ writer.endList(mapFrame);
+ break;
+ case ARRAY_VALUE_CONSTRUCTOR:
+ writer.print(call.getOperator().getName().toLowerCase(Locale.ROOT));
Review Comment:
Yes，I agree with your point if we test empty args in spark dialect, it also
not support:
```
sql("select ARRAY[]").withSpark().ok("select array()");
```
it would error out:
```
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 14: Require at least 1 argument
org.apache.calcite.tools.ValidationException:
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 14: Require at least 1 argument
at org.apache.calcite.prepare.PlannerImpl.validate(PlannerImpl.java:228)
at
org.apache.calcite.rel.rel2sql.RelToSqlConverterTest$Sql.exec(RelToSqlConverterTest.java:9957)
at
org.apache.calcite.rel.rel2sql.RelToSqlConverterTest$Sql.ok(RelToSqlConverterTest.java:9923)
```
Actually all dialects does not support empty args for map/array currently.
At the same time I had tried to remove restrictions and found it would Involves
many aspects which maybe need to file a new jira to trace it.
Whether we can record it as a bug(map/array not support with empty args) and
add empty test case in this PR, then this pr resolve non-empty args for
array/map first? @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
