mihaibudiu commented on code in PR #4346:
URL: https://github.com/apache/calcite/pull/4346#discussion_r2064218950
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -634,6 +641,126 @@ public RelOptPredicateList getPredicates(RelSubset r,
return Util.first(list, RelOptPredicateList.EMPTY);
}
+ /**
Review Comment:
is this changed?
github makes it difficult to tell whether the code was just moved.
why move it anyway?
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -7448,27 +7448,6 @@ LogicalProject(SAL=[$5])
LogicalProject(SAL=[$5], $f9=[=($5, 4)])
LogicalFilter(condition=[AND(=($7, 20), >($5, 1000))])
LogicalTableScan(table=[[CATALOG, SALES, EMPNULLABLES]])
-]]>
Review Comment:
where is the planAfter?
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -194,15 +194,11 @@ public RelOptPredicateList getPredicates(Project project,
final List<RexNode> projectPullUpPredicates = new ArrayList<>();
ImmutableBitSet.Builder columnsMappedBuilder = ImmutableBitSet.builder();
- Mapping m =
- Mappings.create(MappingType.PARTIAL_FUNCTION,
- input.getRowType().getFieldCount(),
- project.getRowType().getFieldCount());
-
+ Map<Integer, BitSet> equivalence = new HashMap<>();
Review Comment:
can you add a comment describing what this map does, including the keys and
values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
