mihaibudiu commented on code in PR #4346:
URL: https://github.com/apache/calcite/pull/4346#discussion_r2067552108
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -966,15 +986,18 @@ protected EquivalenceFinder() {
* b + b + e
* </pre>
*/
- class ExprsItr implements Iterator<Mapping> {
+ static class ExprsItr implements Iterator<Mapping> {
final int[] columns;
final BitSet[] columnSets;
final int[] iterationIdx;
@Nullable Mapping nextMapping;
boolean firstCall;
+ int sourceCount;
+ int targetCount;
@SuppressWarnings("JdkObsolete")
- ExprsItr(ImmutableBitSet fields) {
+ ExprsItr(ImmutableBitSet fields, Map<Integer, BitSet> equivalence,
Review Comment:
I don't see any such usage.
If you are using an IDE, you can remove the warning and see whether it
complains.
Cleaning up code is always useful, even if it is not the goal of your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
