mihaibudiu commented on code in PR #4346:
URL: https://github.com/apache/calcite/pull/4346#discussion_r2067550495
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -966,15 +986,18 @@ protected EquivalenceFinder() {
* b + b + e
* </pre>
*/
- class ExprsItr implements Iterator<Mapping> {
+ static class ExprsItr implements Iterator<Mapping> {
final int[] columns;
final BitSet[] columnSets;
final int[] iterationIdx;
@Nullable Mapping nextMapping;
boolean firstCall;
+ int sourceCount;
+ int targetCount;
@SuppressWarnings("JdkObsolete")
- ExprsItr(ImmutableBitSet fields) {
+ ExprsItr(ImmutableBitSet fields, Map<Integer, BitSet> equivalence,
Review Comment:
```
@SuppressWarnings("JdkObsolete") is an annotation in Java that instructs the
compiler to ignore warnings related to the usage of obsolete APIs from the JDK,
such as old collection classes like Vector, Hashtable, or Enumeration. These
APIs are considered outdated and are generally discouraged in favor of newer,
more efficient alternatives like ArrayList, HashMap, or the Iterator interface.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
