asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2067967167
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1335,7 +1335,9 @@ private LockWrapper exclusiveCleanDb(Connection c) throws
SQLException {
/**
* Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-4619";>[CALCITE-4619]
- * "Full join" generates an incorrect execution plan under mysql</a>. */
Review Comment:
I feel a separate test case would be cleaner, `testFullJoinSupportedDialect`
or similar for those who support it, the existing (untouched?) for those who
don't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
