asolimando commented on code in PR #4351:
URL: https://github.com/apache/calcite/pull/4351#discussion_r2068170003
##########
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java:
##########
@@ -214,6 +214,10 @@ public final class CalciteSystemProperty<T> {
return ".";
});
+
Review Comment:
Let's have them as `private static final` in `JdbcAdapterTest` for now, we
can move them in a "common" location and adjust visibility if they are going to
be used elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
