asolimando commented on PR #4351: URL: https://github.com/apache/calcite/pull/4351#issuecomment-2841079828
> > @xuzifu666 can you check sonar report and fix what makes sense? Thanks! > > In my view，sonar test is success，and other test is ok，which sonar error do you mean？（can show the link to me）@asolimando It's [this link](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4351&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) that gets published as a recap in messages like [this one](https://github.com/apache/calcite/pull/4351#issuecomment-2841049798). In this case there are 6 new issues, some are clearly addressable and correct (dangling imports), some others could be addressed (repetition of string). There might also be false positives sometimes, or debatable issues like "brain methods" etc. which are very much present in the codebase and mostly accepted. In general it's worth checking with grain of salt, not every issue reported has to be addressed, but for trivial things like imports it spares time for everyone and makes the review total time shorter. When you see "success" it means the analysis succeeded, not that there aren't problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
