mihaibudiu commented on code in PR #4350:
URL: https://github.com/apache/calcite/pull/4350#discussion_r2068008986
##########
core/src/main/java/org/apache/calcite/rex/RexPermuteInputsShuttle.java:
##########
@@ -85,9 +101,15 @@ private static ImmutableList<RelDataTypeField>
fields(RelNode[] inputs) {
@Override public RexNode visitInputRef(RexInputRef local) {
final int index = local.getIndex();
int target = mapping.getTarget(index);
- return new RexInputRef(
- target,
- local.getType());
+ if (!isStrictTypeMatch) {
Review Comment:
this doesn't look to me like it's a "strict" comparison
basically you are copying types from different fields: source, or destination
Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
