mihaibudiu commented on code in PR #4350:
URL: https://github.com/apache/calcite/pull/4350#discussion_r2069704363
##########
core/src/main/java/org/apache/calcite/rex/RexPermuteInputsShuttle.java:
##########
@@ -54,14 +55,41 @@ public class RexPermuteInputsShuttle extends RexShuttle {
public RexPermuteInputsShuttle(
Mappings.TargetMapping mapping,
RelNode... inputs) {
- this(mapping, fields(inputs));
+ this(mapping, fields(inputs), false);
+ }
+
+ /**
+ * Creates a RexPermuteInputsShuttle with target type matching control.
+ *
+ * <p>The mapping provides at most one target for every source. If a source
Review Comment:
what I suggested here is that the second phrase and third should be removed.
(If a source... unique target). They do not document what this method does,
they document what getTarget does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
