xiedeyantu commented on code in PR #4350:
URL: https://github.com/apache/calcite/pull/4350#discussion_r2069676014
##########
core/src/main/java/org/apache/calcite/rex/RexPermuteInputsShuttle.java:
##########
@@ -54,14 +55,41 @@ public class RexPermuteInputsShuttle extends RexShuttle {
public RexPermuteInputsShuttle(
Mappings.TargetMapping mapping,
RelNode... inputs) {
- this(mapping, fields(inputs));
+ this(mapping, fields(inputs), false);
+ }
+
+ /**
+ * Creates a RexPermuteInputsShuttle with target type matching control.
+ *
+ * <p>The mapping provides at most one target for every source. If a source
+ * has no targets and is referenced in the expression,
+ * {@link
org.apache.calcite.util.mapping.Mappings.TargetMapping#getTarget(int)}
+ * will give an error. Otherwise the mapping gives a unique target.
+ *
+ * @param mapping Mapping that defines source-to-target relation
+ * @param shouldMatchTargetType If true, enforces use target type when
remapping inputs
Review Comment:
I modified the description of `matchTargetType` according to your
suggestion, and kept the other descriptions unchanged. Do you think it's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
