julianhyde commented on code in PR #4410:
URL: https://github.com/apache/calcite/pull/4410#discussion_r2150104676
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -527,19 +527,29 @@ private boolean expandSelectItem(final SqlNode
selectItem, SqlSelect select,
}
private static SqlNode expandExprFromJoin(SqlJoin join,
- SqlIdentifier identifier, SelectScope scope) {
- if (join.getConditionType() != JoinConditionType.USING) {
+ SqlIdentifier identifier, SelectScope scope, SqlValidatorImpl validator)
{
Review Comment:
Whether you add a parameter or make the method non-static, you will need to
refactor the calling methods.
This sounds like refactoring. Refactoring should not be deferred. Tidy up,
and make things better, as you go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
