julianhyde commented on code in PR #4410:
URL: https://github.com/apache/calcite/pull/4410#discussion_r2152645428
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -527,19 +527,29 @@ private boolean expandSelectItem(final SqlNode
selectItem, SqlSelect select,
}
private static SqlNode expandExprFromJoin(SqlJoin join,
- SqlIdentifier identifier, SelectScope scope) {
- if (join.getConditionType() != JoinConditionType.USING) {
+ SqlIdentifier identifier, SelectScope scope, SqlValidatorImpl validator)
{
+ if (join.getConditionType() != JoinConditionType.USING &&
!join.isNatural()) {
Review Comment:
I mean you can change
```
if (join.getConditionType() != JoinConditionType.USING &&
!join.isNatural()) {
return identifier;
}
List<String> commonColumnNames;
// must be natural or using here, and cannot specify NATURAL keyword
with USING clause
if (join.isNatural()) {
commonColumnNames = validator.deriveNaturalJoinColumnList(join);
} else {
commonColumnNames = SqlIdentifier.simpleNames((SqlNodeList)
getCondition(join));
}
```
to
```
if (join.isNatural()) {
commonColumnNames = validator.deriveNaturalJoinColumnList(join);
} else if (join.getConditionType() == JoinConditionType.USING) {
commonColumnNames = SqlIdentifier.simpleNames((SqlNodeList)
getCondition(join));
} else {
return identifier;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
