mihaibudiu commented on code in PR #4431: URL: https://github.com/apache/calcite/pull/4431#discussion_r2161964255
########## site/_docs/reference.md: ########## @@ -2832,7 +2832,8 @@ In the following: | b | CODE_POINTS_TO_BYTES(integers) | Converts *integers*, an array of integers between 0 and 255 inclusive, into bytes; throws error if any element is out of range | b | CODE_POINTS_TO_STRING(integers) | Converts *integers*, an array of integers between 0 and 0xD7FF or between 0xE000 and 0x10FFFF inclusive, into string; throws error if any element is out of range | o r | CONCAT(string, string) | Concatenates two strings, returns null only when both string arguments are null, otherwise treats null as empty string -| b m | CONCAT(string [, string ]*) | Concatenates one or more strings, returns null if any of the arguments is null +| b | CONCAT(string [, string ]*) | Concatenates one or more strings, returns null if any of the arguments is null +| m | CONCAT(any [, any ]*) | Concatenates one or more strings/bytestrings/..., if arguments contains bytestring would return bytes string and returns null if any of the arguments is null Review Comment: That's not correct. The function only accepts CHAR and BINARY arguments; the other arguments are accepted because the compiler ill insert implicit casts. That's a completely separate issue, which has no bearing to this function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
