mihaibudiu commented on code in PR #4431:
URL: https://github.com/apache/calcite/pull/4431#discussion_r2162057050
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1655,6 +1655,34 @@ public static String concatMulti(String... args) {
return String.join("", args);
}
+ /** SQL {@code CONCAT(obj0, obj1, obj2, ...)} function. */
+ public static String concatMultiObjects(Object... args) {
Review Comment:
I am afraid this will cause problems for more general programs.
The Java code generated by the enumerable implementation is relatively
strongly typed, and it will expect ByteArray for the result of some calls.
Please add some quidem tests to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
