xuzifu666 commented on code in PR #4431:
URL: https://github.com/apache/calcite/pull/4431#discussion_r2175156053
##########
core/src/test/resources/sql/functions.iq:
##########
@@ -184,6 +185,81 @@ SELECT CONCAT('a');
!ok
+SELECT CONCAT('a', 'b', 'c');
++--------+
+| EXPR$0 |
++--------+
+| abc |
++--------+
+(1 row)
+
+!ok
+
+SELECT CONCAT('a', x'61');
++--------+
+| EXPR$0 |
++--------+
+| 6161 |
++--------+
+(1 row)
+
+!ok
+
+SELECT CONCAT(x'61', x'62');
++--------+
+| EXPR$0 |
++--------+
+| 6162 |
++--------+
+(1 row)
+
+!ok
+
+SELECT CONCAT('a', x'61', null);
++--------+
+| EXPR$0 |
++--------+
+| |
++--------+
+(1 row)
+
+!ok
+
+SELECT CONCAT(cast(1 as varchar), 'a');
Review Comment:
https://issues.apache.org/jira/browse/CALCITE-7078 had been resolve now， I
had some problems using it before，It can support Chinese characters, and I
added Chinese and binary tests, and the results should be in line with
expectations.
```
SELECT CONCAT(x'61', _UTF8'方解石');
+----------------------+
| EXPR$0 |
+----------------------+
| 61e696b9e8a7a3e79fb3 |
+----------------------+
(1 row)
```
PTAL @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
