mihaibudiu commented on code in PR #4339: URL: https://github.com/apache/calcite/pull/4339#discussion_r2223965561
########## core/src/test/resources/sql/operator.iq: ########## @@ -702,4 +702,54 @@ FOO BOOLEAN(1) NOT NULL !ok +SELECT 2 ^ 3 AS foo; Review Comment: these tests are all tests with constants, please add some non-constant tests, e.g., using empno/empid. Also, please mix operand types. That's the whole point of iq test - they can run on table data. Better coverage than operator tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
