Dwrite commented on PR #4339:
URL: https://github.com/apache/calcite/pull/4339#issuecomment-3116302310

   > The problem is the following: the testing framework uses a "consumer" to 
check the results, with the same API used for negative and positive test cases. 
There is an implicit assumption that only negative tests may have carets in the 
SQL strings. So when a positive test is executed, the code paths for handling 
escaped carets are never executed. I will see whether I can fix this.
   
   Got it, thanks again for the explanation! Just to confirm — would you 
suggest I hold off on this PR until the testing framework is updated, or is 
there anything you'd prefer me to adjust in the meantime?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to