mihaibudiu commented on code in PR #4491:
URL: https://github.com/apache/calcite/pull/4491#discussion_r2255434205
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2210,7 +2210,7 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "INNER JOIN \"foodmart\".\"sales_fact_1997\" ON
\"product\".\"product_id\" = \"sales_fact_1997\".\"product_id\"\n"
+ "GROUP BY \"product\".\"product_id\"\n"
+ "HAVING COUNT(*) > 1) AS \"t2\"\n"
- + "WHERE \"t2\".\"product_id\" > 100";
+ + "WHERE \"product_id\" > 100";
Review Comment:
you could avoid this change by returning the builder as in the original code
when none of the conditions for the error occurs.
But if you are confident that this is always correct as well, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
