dssysolyatin commented on PR #4491:
URL: https://github.com/apache/calcite/pull/4491#issuecomment-3158707017

   > LGTM, I'm curious, if that's the case, would a type like Project also need 
similar handling such as result(builder.select, builder.clauses, e, null)?
   
   Good question, It's definitely worth looking into if you have some time. 
`RelToSqlConverter` code is a bit hard to follow, and different cases should be 
checked separately
   
   Thanks for the approval. I will wait until Friday. If there are no 
objections by then, I will merge the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to