mihaibudiu commented on code in PR #4491:
URL: https://github.com/apache/calcite/pull/4491#discussion_r2261047196
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -553,6 +554,83 @@ private static String toSql(RelNode root, SqlDialect
dialect,
sql(query).ok(expected);
}
+ /**
+ * Tests that an identity project is pruned over sca during SQL conversion,
Review Comment:
typo for "scan"?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -553,6 +554,83 @@ private static String toSql(RelNode root, SqlDialect
dialect,
sql(query).ok(expected);
}
+ /**
+ * Tests that an identity project is pruned over sca during SQL conversion,
+ * and that the correct table alias is propagated to the final projection.
+ */
+ @Test void testPruneIdentityProjectOverScan() {
+ final RelBuilder relBuilder =
+ RelBuilder.create(// Disable merge-project optimization by RelBuilder
to generate a plan
Review Comment:
I would start the comment on the next line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
