dssysolyatin commented on code in PR #4553:
URL: https://github.com/apache/calcite/pull/4553#discussion_r2431704091
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -2204,6 +2208,25 @@ protected void inferUnknownTypes(
}
}
+ private boolean isRowSqlNodeList(final RelDataType inferredType, final
SqlNodeList nodeList) {
+ return inferredType.isStruct() && !nodeList.isEmpty()
+ && SqlKind.ROW == nodeList.get(0).getKind();
Review Comment:
Also, I have one more question, you return from the function if at least one
element of kind `SqlKind.ROW`, but what about the other elements that might not
be of kind `SqlKind.ROW`?
```java
if (isRowSqlNodeList(inferredType, nodeList)) {
inferRowSqlNodeList(inferredType, scope, nodeList);
return; <-- why we return here
}
```
Why do we return and skip the rest of the logic at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
