strongduanmu commented on code in PR #4553:
URL: https://github.com/apache/calcite/pull/4553#discussion_r2434557499
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -19738,15 +19729,9 @@ LogicalProject(A=[$0], Y=[$1])
LogicalUnion(all=[true])
LogicalProject(EXPR$0=[1], EXPR$1=[2])
LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[3], EXPR$1=[null:INTEGER])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[7369], EXPR$1=[null:INTEGER])
- LogicalValues(tuples=[[{ 0 }]])
LogicalProject(EXPR$0=[null:INTEGER], EXPR$1=[20])
LogicalValues(tuples=[[{ 0 }]])
- LogicalProject(EXPR$0=[null:INTEGER], EXPR$1=[5])
- LogicalValues(tuples=[[{ 0 }]])
- LogicalValues(tuples=[[{ 7499, 30 }]])
+ LogicalValues(tuples=[[{ 3, null }, { 7369, null }, { 7499, 30 }, {
null, 5 }]])
Review Comment:
I looked at the code and found that the SqlToRelConverter#convertRowValues
method merges RexLiteral into LogicalValues. In this case, the values that
cannot be converted to LogicalValues are `(cast(1.1 as int), 2)` and `(null,
cast(20.2 as int))`, which have type conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
