strongduanmu commented on code in PR #4553: URL: https://github.com/apache/calcite/pull/4553#discussion_r2377402937
########## core/src/test/resources/sql/conditions.iq: ########## @@ -547,4 +547,21 @@ where 5 < cast(deptno as integer) OR 5 >= cast(deptno as integer) OR deptno IS N EnumerableTableScan(table=[[scott, EMP]]) !plan +!use scott + +# Test case for [CALCITE-7197] UnsupportedOperationException when using dynamic parameters inside ROW expression +select * +from "scott".emp +where row(empno, ename) in ((7782, 'CLARK'), (7902, 'FORD'), (7839, 'KING')); ++-------+-------+-----------+------+------------+---------+------+--------+ Review Comment: Before this PR, including literals in ROW worked fine, but there were no tests covering this scenario. Considering that this PR modifies the validate logic, adding such a test will help with the regression of row literals scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
