xiedeyantu commented on code in PR #4586:
URL: https://github.com/apache/calcite/pull/4586#discussion_r2443320208
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
Review Comment:
Maybe change this name to `converted`?
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -10335,7 +10335,7 @@ on emp.deptno=dept.deptno and emp.ename is not null]]>
<Resource name="planBefore">
<![CDATA[
LogicalProject(EXPR$0=[1])
- LogicalJoin(condition=[AND(=($7, $9), IS NOT NULL($1))], joinType=[inner])
+ LogicalJoin(condition=[=($7, $9)], joinType=[inner])
Review Comment:
Why is the `IS NOT NULL($1)` condition being eliminated here? I'm not quite
following the reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
