mihaibudiu opened a new pull request, #4586: URL: https://github.com/apache/calcite/pull/4586
This is the third PR for solving the same issue. I apologize for the repeats, but I discovered that the previous solution was not completely satisfactory. What happens is that if one configures the `builder.withSimplify(false)` join predicates can be left "malformed" and trigger an assertion failure. (A malformed predicate is a comparison against null; the analyses which perform predicate pull down assert that there are no such predicates). The solution is to simplify the join predicates unconditionally, in similar way we did simplification (in the previous PR for this issue) for Filters. Now, it is perhaps strange that one prohibits the builder from simplifying and then we do these simplifications unconditionally. However, notice that we are only simplifying predicates which cannot be left malformed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
