mihaibudiu commented on code in PR #4586:
URL: https://github.com/apache/calcite/pull/4586#discussion_r2445782034
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -10335,7 +10335,7 @@ on emp.deptno=dept.deptno and emp.ename is not null]]>
<Resource name="planBefore">
<![CDATA[
LogicalProject(EXPR$0=[1])
- LogicalJoin(condition=[AND(=($7, $9), IS NOT NULL($1))], joinType=[inner])
+ LogicalJoin(condition=[=($7, $9)], joinType=[inner])
Review Comment:
This is exactly the problem that this PR is addressing: pullUpPredicates
will assert fail if it finds predicates that compare against null. In the
previous version of this PR (which is merged) we made sure there are no such
predicates in WHERE clauses. In this version of the PR we remove them from
JOINs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
